Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable JSON #22

Open
Djboy08 opened this issue Nov 14, 2023 · 10 comments
Open

Editable JSON #22

Djboy08 opened this issue Nov 14, 2023 · 10 comments

Comments

@Djboy08
Copy link

Djboy08 commented Nov 14, 2023

Does this library not support editable json?

My use case is I want the end-user to be able to edit the JSON and save it later but the only thing I could see is "contentEditable".
But this realistically is not what I want since that gives too much control and allows them to basically just type text.

@jaywcjlove
Copy link
Member

@Djboy08 1.0 supports editing functions, 2.0 is still under study, and development is still in progress.

@Djboy08
Copy link
Author

Djboy08 commented Nov 17, 2023

Is the rows virtualized too? Every react json editor I come across is not virtualized, thus causing a massive data output to lag the browser.

@jaywcjlove
Copy link
Member

@Djboy08 Virtualization is not supported, can an option be added to load more?

@Djboy08
Copy link
Author

Djboy08 commented Nov 18, 2023

This is very unfortunate, it seems all the editable react components out there just are not virtualized and its a shame.

In my case loading more could have many different ways to implement. All of which that is bad UX/UI. It seems I may just go for a monaco editor as a JSON editor as that can support a massive json, all of which is expanded without the browser dying

@mikeyaa
Copy link

mikeyaa commented Jan 28, 2024

+1 for editing on v2.0

@brunitob
Copy link

+1 for editing on v2.0 🤝

@ethndotsh
Copy link

+1 for editing on v2.0

@shin616122
Copy link

Any timeline for this?..
Not sure if I should downgrade to 1.0.0 to use editable json or not...

@jaywcjlove
Copy link
Member

@shin616122 I don’t have time to plan the release of version 2.0 right now, but I’ll continue to maintain it. If I’m interested, I might add the editing feature. Due to life circumstances, I’m developing some macOS applications to make a living, so I don’t have any immediate plans for this component’s editing feature as it’s more complex.

@shin616122
Copy link

@jaywcjlove
Ok understood
Thank you for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants