Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18N #92

Closed
vinicius-camara opened this issue Sep 2, 2020 · 4 comments
Closed

I18N #92

vinicius-camara opened this issue Sep 2, 2020 · 4 comments
Assignees
@mikecao
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@vinicius-camara
Copy link

Is it possible add support to i18N?
@mikecao
Copy link
Collaborator

mikecao commented Sep 2, 2020

Yes, planning to do it soon.

@mikecao mikecao added the enhancement New feature or request label Sep 2, 2020
@mikecao mikecao self-assigned this Sep 2, 2020
@mikecao
Copy link
Collaborator

mikecao commented Sep 7, 2020

I've got i18N working on the dev branch right now. If anyone wants to provide translations it'd be greatly appreciated. Just copy the lang/en.json file and translate all the defaultMessage strings and save as a new file with locale code like fr.json or es.json.

@mikecao mikecao added the help wanted Extra attention is needed label Sep 7, 2020
@mikecao mikecao pinned this issue Sep 7, 2020
@mikecao
Copy link
Collaborator

mikecao commented Sep 8, 2020 •
edited
Loading

dev branch has been merged into master. There is a file called lib/lang.js that defines all the supported languages and functions. You will need to update it if you are doing local development. Otherwise you can just provide an updated lang/[id].json file and I can update for you.

@mikecao
Copy link
Collaborator

mikecao commented Sep 8, 2020

@err931 Yes please use the BCP47 code. You can either submit to dev or master. I'll make sure it's merged either way.

@mikecao mikecao closed this as completed Sep 30, 2020
@mikecao mikecao unpinned this issue Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikecao mikecao

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vinicius-camara @mikecao