-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ImageSharp.Web to V2.0.0 #12300
Comments
This is in the works: #12185 |
@nul800sebastiaan Thanks for that I hadn't searched for Pull Requests only under issues - doh! Am I reading this correctly that V2.0.0 will not be used on V9? |
That's correct, due to breaking changes and the upcoming 9.5 being the last version of 9 we won't be able to include an updated version of ImageSharp in v9. v10RC is due out in a few weeks though, so you'll get your hands on it soon enough. |
Closing this as it was fixed for v10.0.0 - #12185 |
Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9
V9.4.3
Bug summary
To be able to use AWS S3 for storage of image files ImageSharp.Web needs to be at version 2.0.0 to include SixLabors/ImageSharp.Web#209.
Specifics
The issue is to pull in code for the AWS S3 File Provider (see File Provider @ https://github.com/andyfelton-equatedigital/Umbraco.StorageProviders.AWSS3)
Steps to reproduce
These details are from the Umbraco.StorageProviders.AWSS3.
Note to use on the current version (1.0.5) of ImageSharp.Web and Umbraco the following must be done:
Build Umbraco.Web.Common against the version of ImageSharp.Web on MyGet
ImageSharp.Web includes a breaking change, change CropWebProcessor.cs as shown here https://gist.github.com/andyfelton-equatedigital/9e5e02dd1ff53f3639e293ce911b7fba
Use your version of Umbraco.Web.Common on your project
Expected result / actual result
Able to include https://github.com/andyfelton-equatedigital/Umbraco.StorageProviders.AWSS3 without having to rebuild Umbraco.
The text was updated successfully, but these errors were encountered: