Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ImageSharp.Web to V2.0.0 #12300

Closed
andyfelton-equatedigital opened this issue Apr 25, 2022 · 4 comments · Fixed by #12185
Closed

Upgrade ImageSharp.Web to V2.0.0 #12300

andyfelton-equatedigital opened this issue Apr 25, 2022 · 4 comments · Fixed by #12185
Labels

Comments

@andyfelton-equatedigital

Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9

V9.4.3

Bug summary

To be able to use AWS S3 for storage of image files ImageSharp.Web needs to be at version 2.0.0 to include SixLabors/ImageSharp.Web#209.

Specifics

The issue is to pull in code for the AWS S3 File Provider (see File Provider @ https://github.com/andyfelton-equatedigital/Umbraco.StorageProviders.AWSS3)

Steps to reproduce

These details are from the Umbraco.StorageProviders.AWSS3.

Note to use on the current version (1.0.5) of ImageSharp.Web and Umbraco the following must be done:

Build Umbraco.Web.Common against the version of ImageSharp.Web on MyGet
ImageSharp.Web includes a breaking change, change CropWebProcessor.cs as shown here https://gist.github.com/andyfelton-equatedigital/9e5e02dd1ff53f3639e293ce911b7fba
Use your version of Umbraco.Web.Common on your project

Expected result / actual result

Able to include https://github.com/andyfelton-equatedigital/Umbraco.StorageProviders.AWSS3 without having to rebuild Umbraco.

@nul800sebastiaan nul800sebastiaan linked a pull request Apr 25, 2022 that will close this issue
4 tasks
@nul800sebastiaan
Copy link
Member

This is in the works: #12185

@andyfelton-equatedigital
Copy link
Author

@nul800sebastiaan Thanks for that I hadn't searched for Pull Requests only under issues - doh!

Am I reading this correctly that V2.0.0 will not be used on V9?

@nul800sebastiaan
Copy link
Member

That's correct, due to breaking changes and the upcoming 9.5 being the last version of 9 we won't be able to include an updated version of ImageSharp in v9. v10RC is due out in a few weeks though, so you'll get your hands on it soon enough.

@nul800sebastiaan
Copy link
Member

nul800sebastiaan commented Jul 12, 2022

Closing this as it was fixed for v10.0.0 - #12185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants