Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node selection should be indicated for screen readers #14520

Open
plannero opened this issue Jul 7, 2023 · 3 comments
Open

Node selection should be indicated for screen readers #14520

plannero opened this issue Jul 7, 2023 · 3 comments

Comments

@plannero
Copy link

plannero commented Jul 7, 2023

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

10.4.0

Bug summary

In the ”move page” panel, when you select a destination node, the selection is visually indicated with a “check” symbol. But for non-sighted users this information is not available at all.

Specifics

You should set aria-selected or aria-checked attribute (depending on element role) for the node at the same time as toggling the symbol.
node-selected

Steps to reproduce

This problem appears when you want to move a node in the content tree, as you select a destination (parent node), while using a screen reader.

Expected result / actual result

After selecting a parent node as destination, the selected node should be announced as selected by the screen reader, so that you know you did a proper selection before saving changes.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Hi there @plannero!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@elit0451
Copy link
Member

elit0451 commented Jul 7, 2023

Thank you for raising this concern @plannero 🙌

We encourage you to submit a PR with your suggestion! I will mark this as up for grabs in case you or anyone else wants to help us fix this. 🙂

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Hi @plannero,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants