Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UmbracoHelper does not contain a definition for RenderMacroAsync #17020

Closed
s-ryan opened this issue Sep 6, 2024 · 3 comments
Closed

UmbracoHelper does not contain a definition for RenderMacroAsync #17020

s-ryan opened this issue Sep 6, 2024 · 3 comments
Labels

Comments

@s-ryan
Copy link

s-ryan commented Sep 6, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.1.1

Bug summary

UmbracoHelper does not contain a definition for RenderMacroAsync

// render pest treatment using the pest theme
if (_formGuid.ToString() == "50e1840c-a41b-4e02-84a7-508f2c7e4be2")
{
await Umbraco.RenderMacroAsync("renderUmbracoForm", new { FormGuid = Model.Value("formGuid"), FormTheme = "pesttreatment", ExcludeScripts = "1" });

}

Specifics

We are attempting to render a form using a specific theme. The documentation advises:

When you are rendering your form directly in your template, you need to specify your theme by filling out the FormTheme attribute:

@await Umbraco.RenderMacroAsync("renderUmbracoForm", new {FormGuid="1ec026cb-d4d3-496c-b8e8-90e0758c78d8", FormTheme="MyFormTheme", ExcludeScripts="0"})
If you do not pick and/or set a theme, the default theme will be used to render the form.

https://docs.umbraco.com/umbraco-forms/developer/themes

However the UmbracoHelper does not contain a definition for RenderMacroAsync

Steps to reproduce

image

Expected result / actual result

Ability to render a form using a specified theme

@s-ryan s-ryan added the type/bug label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

Hi there @s-ryan!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@enkelmedia
Copy link
Contributor

Macros was removed from Umbraco with the release of v14, I think you need to render your forms using a view component.

@await Component.InvokeAsync("RenderForm", new { formId = Guid.Parse("<form guid>"), theme = "default", includeScripts = false })

https://docs.umbraco.com/umbraco-forms/developer/rendering-forms

I think that issue here is that the docs has not been updated to reflect the fact that macros has been removed.

I submitted a issue in the docs-repo umbraco/UmbracoDocs#6443

@iOvergaard
Copy link
Contributor

Hello @s-ryan,

As @enkelmedia has stated, Macros were deprecated in Umbraco 13 and ultimately removed in Umbraco 14. There is something missing in the docs, so I appreciate your contribution, @enkelmedia.

I hope this helps you on your way, @s-ryan. I will proceed with closing this issue as it seems a documentation change is what is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants