-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Vary by culture" toggle missing for properties on document type #17111
Comments
Hi there @gab-trifork! Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better. We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.
We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hi @gab-trifork, this issue is serious, but I'm having difficulty reproducing it. The toggle should be shown as long as the document type itself is also marked as "Allow vary by culture" in the "Settings" tab: Will you let me know if that works, please? |
Hello @iOvergaard |
Sorry, I have 2 Umbraco projects and it turns out I accidentally ran the incorrect one, generating a new project using |
Good and bad news at the same time, @gab-trifork. Do let me know what you figure out! |
Okay, so I have managed to do a minimal reproduction.
if you stop the server and delete the usync package again, the toggle will reappear my deps:
|
@gab-trifork great, I can certainly reproduce that. Thank you so much for the reproducible steps. The variation toggle is gone when usync.complete 14.2 was just released last week and this bug might have flown under their radar until now. Honestly, I would report it directly to them on their Github issues tracker and refer back to this thread. The technical explanation is as follows: The UI component needs to know that the context bearing the token |
@iOvergaard |
It's fine, @gab-trifork. Cheers! |
Hi, We've tracked this down in the uSync.Complete code, for reference (and maybe as a place to look if it happens with someone else). we had a missing condition. as in we had a workspace context manifest that didn't limit the workspace context by condition. const context: ManifestWorkspaceContext = {
type: 'workspaceContext',
alias: 'usync.publisher.server.workspace.context',
name: 'Publisher workspace context',
js: () => import('./server-workspace.context'),
}; we added the correct condition and that fixed is. const context: ManifestWorkspaceContext = {
type: 'workspaceContext',
alias: 'usync.publisher.server.workspace.context',
name: 'Publisher workspace context',
js: () => import('./server-workspace.context'),
conditions: [
{
alias: 'Umb.Condition.WorkspaceAlias',
match: USYNC_PUBLISHER_SERVER_WORKSPACE_ALIAS,
},
],
}; the context itself is not doing anything 'suspicious' (not from my eyes anyway). so not 100% sure why it breaks this and only this bit of the datatype but that does look like what it was doing 🤷 |
Hi @KevinJump I'm amazed by your investigation skills - great find. I'm not sure why that would have an effect, but I did see the publisher* contexts (by placing a |
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
14.2.0
Bug summary
When configuring properties on a document type, the toggle to allow properties to vary by culture is missing.
(Downgrading to 14.1.2 makes the toggle come back)
Specifics
No response
Steps to reproduce
Set up a blank Umbraco project using
dotnet new umbraco
and follow the steps for adding culture varied content:https://docs.umbraco.com/umbraco-cms/fundamentals/backoffice/variants
When on the step
To allow a property on the Document Type to be varied it will have to be enabled for the property:
notice that there is no toggle for enabling "vary by culture" for the property.Expected result / actual result
The toggle is there, letting me decide whether properties are variant or invariant
The text was updated successfully, but these errors were encountered: