Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution not buid in VS 2022 #17155

Closed
ednsinf opened this issue Sep 28, 2024 · 5 comments
Closed

Solution not buid in VS 2022 #17155

ednsinf opened this issue Sep 28, 2024 · 5 comments
Labels
state/needs-more-info We don't have enough information to give a good reply type/bug

Comments

@ednsinf
Copy link

ednsinf commented Sep 28, 2024

Solution not buid in VS 2022

Bug summary

Severity Code Description Project File Line Suppression State
Error (active) MSB4044 The "GetUmbracoBuildVersion" task was not given a value for the required parameter "GitCommitIdShort". Umbraco.Cms, Umbraco.Cms.Api.Common, Umbraco.Cms.Api.Delivery, Umbraco.Cms.Api.Management, Umbraco.Cms.Imaging.ImageSharp, Umbraco.Cms.Imaging.ImageSharp2, Umbraco.Cms.Persistence.EFCore, Umbraco.Cms.Persistence.EFCore.Sqlite, Umbraco.Cms.Persistence.EFCore.SqlServer, Umbraco.Cms.Persistence.Sqlite, Umbraco.Cms.Persistence.SqlServer, Umbraco.Cms.StaticAssets, Umbraco.Cms.Targets, Umbraco.Core, Umbraco.Examine.Lucene, Umbraco.Infrastructure, Umbraco.JsonSchema, Umbraco.PublishedCache.NuCache, Umbraco.Templates, Umbraco.TestData, Umbraco.Tests.AcceptanceTest.UmbracoProject, Umbraco.Tests.Benchmarks, Umbraco.Tests.Common, Umbraco.Tests.Integration, Umbraco.Tests.UnitTests, Umbraco.Web.Common, Umbraco.Web.UI, Umbraco.Web.Website C:\Users\e_dns.nuget\packages\umbraco.gitversioning.extensions\0.2.0\build\Umbraco.GitVersioning.Extensions.targets 5

Steps to reproduce

Whwn open solution in VS 2022

Expected result / actual result

Build

Copy link

Hi there @ednsinf!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@iOvergaard
Copy link
Contributor

Hello @ednsinf,
Your error log says that the MSBuild task "GetUmbracoBuildVersion" is failing. This issue arises from tools installed through Nuget. Please ensure you are on the latest .NET 9 Release Candidate as the main branch requires that. Please also ensure that you have restored all nuget packages after installing that. Let me know if that works for you!

@dawoe
Copy link
Contributor

dawoe commented Oct 2, 2024

@iOvergaard could also be that @ednsinf just downloaded the source and not cloned it.
In that case you don't have a git repo and the git version tasks will fail.
See https://dev.to/dawoe/debugging-the-umbraco-source-code-for-specific-version-5ahk

@iOvergaard
Copy link
Contributor

Oh, good point, @dawoe. That is perhaps something worth looking into to get the source to work without a git repository.

@ednsinf, when you get time, please report back if you are using the Git version or direct source code of Umbraco.

@iOvergaard iOvergaard added the state/needs-more-info We don't have enough information to give a good reply label Oct 2, 2024
@nul800sebastiaan
Copy link
Member

Hi @ednsinf! Please note: you typically won't need to build Umbraco from the source code unless your goal is to contribute to its development. Umbraco is designed to be highly extensible and flexible, allowing you to build and customize it to your specific needs without accessing the core source code. Instead, we recommend installing Umbraco as described in the documentation, and then extending it through available tools and frameworks to suit your requirements.

However, if you're interested in contributing to Umbraco, we'd love to hear more! Let us know what you're trying to do, and we’ll be happy to help you get started.

@iOvergaard iOvergaard closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state/needs-more-info We don't have enough information to give a good reply type/bug
Projects
None yet
Development

No branches or pull requests

4 participants