Make XPATH filter work when MNTP is placed on a member/media type

[Ric-Carey]

Hi,

Noticed this on v8.6.3 to might not be relevant any more but:

If you put an xpath query in a multi-node picker to determine what nodes are shown, when you pick that MNTP on a Member, it doesn’t recognise the filter and just shows the full tree. Explicitly choosing the node, works but the xpath isn’t recognised despite it working on the content tree side of things. Its probably something to do with context but really it should be consistent across sections.

Cheers
Ric

[nul800sebastiaan]

Yeah it looks like when you put an MNTP on a member type, it doesn't have the proper context. The MNTP was originally only built to work on content items. I would assume it also doesn't work if you put it on a media item.

We'd be happy to look at a fix if possible! It's been like this forever and I don't remember anyone else asking for this so maybe don't spend a ton of time on it if it turns out it's super complicated.

[umbrabot]

Hi @Ric-Carey,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly Umbraco GitHub bot :-)

[bjarnef]

I think the main issue here it that it use $routeParams.id which is the current node id (a bit misleading the variable is named rootId).
https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/views/propertyeditors/contentpicker/contentpicker.controller.js#L243

I think when an XPath query is configurated we can assume it should always use content or media as XPath doesn't work with members. Actually not sure if XPath is supported on media in Umbraco v8 - at least UmbracoHelper only has ContentAtXPath() and ContentSingleAtXPath(). Generally Xpath isn't necessary in v8, but used a few places to support XPath on MNTP.

Anyway I think we can assume XPath should only work on content since this current entityResource.getByQuery() in ContentPicker / MNTP only lookup Document entity type.

In content section you know what $site and $root is, but in media and members section you don't know what $site as you can have several site nodes.

[bjarnef]

I noticed ent in media and member section is null
https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/views/propertyeditors/contentpicker/contentpicker.controller.js#L244

[bjarnef]

Not fixing all use-cases, but a enhancement when you only have a single node at root 👍
#10049

[umbrabot]

Closing this in relation to PR #10049 - make sure to read the close reason on #10049

[umbrabot]

Closing this in relation to PR #10052 - make sure to read the close reason on #10052