Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6px Body Padding #1487

Open
paskal opened this issue Sep 12, 2022 Discussed in #1465 · 1 comment
Open

6px Body Padding #1487

paskal opened this issue Sep 12, 2022 Discussed in #1465 · 1 comment
Labels

Comments

@paskal
Copy link
Collaborator

paskal commented Sep 12, 2022

Discussed in #1465

Originally posted by Ivan-Chupin August 23, 2022
I've noticed that Remark42 doesn't fit perfectly into the frame intended for it. Remark.css -> body{padding:6px} was to blame. I think this is wrong, because such indents should be carried out exclusively by the layout designer of the site.

@paskal Unfortunately, I have no experience with jsfiddle, and besides, it is not available in the country where I am located. Therefore, I will try to explain in words and pictures.

If I put a Remark42 in a <div></div> then I naturally expect the Remark42 elements to align to the edges of the div. But since Remark42 uses a 6 point padding from each side of the div, this breaks the layout design.

Left as it is now, right as it should be:
Remark42-Padding-2
Why does Remark42 use body{padding: 6px}? Why is the padding not 2 or 10? The answer is absolutely obvious - because it is a crutch that masks the incorrect layout of Remark42.

I think it's a valid issue worth addressing.

@paskal paskal changed the title Body Padding 6px Body Padding Sep 12, 2022
@state303
Copy link

Any updates on this issue?
I know the fix may be a bit trivial, but is somewhat bogging my mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants