Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject multiple votes from the same IP #400

Closed
umputun opened this issue Jul 31, 2019 · 1 comment
Closed

Reject multiple votes from the same IP #400

umputun opened this issue Jul 31, 2019 · 1 comment

Comments

@umputun
Copy link
Owner

umputun commented Jul 31, 2019

The idea is to add an optional restriction treating vote request from the same IP as a vote from the same user. Technically, this is not per IP as we don't store it, but the hash of IP. Either way, this info can be extracted, saved, and analyzed.

This change may not be friendly for users behind some proxy (sharing ip) and will be off by default

@umputun
Copy link
Owner Author

umputun commented Jul 31, 2019

One more thing - if we extend voting info anyway, we can also include timestamp which may help to fine-tune same-ip rejection by limiting this check to some predefined time window.

The biggest problem with this task is how to keep it back-compatible with the current Votes map[string]bool stored in bolt for existing comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant