-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocking hides entire thread #593
Comments
//cc @webkonstantin in a case side panel is something custom to radio-t.com and not standard functionality of remark42: it shows blocked users comment for me. |
Could you please clarify what exactly needs to be done |
@webkonstantin I see blocked users' comments in the side panel. I think it would be better to retrieve them respecting the user's settings, e.g. without showing comments from users who are blocked for him or her. |
Not sure I get it either. This is not smth UI should handle anyway as it supposed to display whatever /last call returned. From the backed point of view blocked user doesn't necessary means comments removed. As you can see even if user blocked with some TTL we still show comments. Complete removal happens on permanent blocking only. |
My bad on terminology: I wouldn’t expect to see users which I personally hidden. |
ok, so to rephrase - are you saying last comments (widget?) shows a hidden user? or this is some sort of issue in the custom widget on the particular site? |
Yes, side comments widget on radio-t.com shows users who I personally hid from my interface. Seems like the reason is /last endpoint handler which doesn't check if a user is logged and doesn't check user's hide settings. If we are willing to fix that, we might want to create a separate issue to prevent scope creep I believe. |
I think we don't handle hidden users on the backend at all. According to #291 this was done as UI side only thing |
|
My vote for 2. is to support it on the backend, as otherwise, you can't rely on /last returning the proper amount of comments to requester. If the backend knows about users particular user hid, I could do it. |
|
The idea was to hide all comments, i.e. hide the user. The reasons why we do it on the frontend side only and don't have any API:
My vote is for keeping it on the frontend side but not hiding replies. Regarding the widget of last comments - if we can't share the info about the hidden users across widgets I don't see it as a big issue or even an issue we really care about. Yeah, last comment widget will show hidden users, not a big deal. The goal was not to prevent anything about hidden users everywhere but reduce noise/unwanted comments. I don't think the last comment widget is what as significant source of the noise anyway. |
To clarify what should be done here to whoever will pick it up: After pushing the "Hide" button under comment now remark hides it and all other comments by that user and all replies to that user comments. Desired state: comment in question and all other comments by that user are hidden or greyed out, but replies to them are visible as usual. |
Link for test.
Current view for logged in user:
If you hide the answer of the first reply author:
As you can see, complete thread is hidden. I wouldn't know about this but I see both comments from user and replies in the hidden thread in the comments section to the right on radio-t.com (example with a random comment to show the panel I've mentioned):
The text was updated successfully, but these errors were encountered: