Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for frontend #93

Closed
igoradamenko opened this issue Jun 23, 2018 · 6 comments
Closed

Add tests for frontend #93

igoradamenko opened this issue Jun 23, 2018 · 6 comments

Comments

@igoradamenko
Copy link
Collaborator

After adding mocks in #86 it's important to cover frontend by E2E-tests.

You are welcome to start this journey with a little PR which configures env for testing and adds some examples of them.

@igoradamenko
Copy link
Collaborator Author

Thanks @Mavrin for testing env which he set up in #100. Right now we need to cover our UI by tests.

I think we need to start from adding mocks (#86), then add some coverage counting tool (if it's possible for this tasks), and then write tests and try to cover the biggest part :-)

@slawiko
Copy link
Contributor

slawiko commented Jun 26, 2018

@igoradamenko don't forget about #96 . Smaller components easier to test. I propose to first split huge components on atomic parts and then add testing.

@umputun umputun modified the milestones: v1.1, v1.2 Jan 6, 2019
@umputun umputun removed this from the v1.2 milestone Jan 21, 2019
@umputun
Copy link
Owner

umputun commented Apr 15, 2019

@Reeywhaar - was it addressed as a part of your massive refactoring? Can you take a look at issues like this one and update? I'm trying to prepare a new release and want to attach the list of tickets we have addressed

@Reeywhaar
Copy link
Collaborator

This is is indeed stale, it's tricky to write frontend tests properly, and no one bothers, including me. Though there is a lot of issues that were fixed long ago.

@akellbl4
Copy link
Collaborator

I think this issue not actual for now.
We have env for testing and some test, also we write tests for new features and write test in places what we change.

@paskal paskal added this to the v1.11.0 milestone Jan 15, 2023
@paskal
Copy link
Sponsor Collaborator

paskal commented Jan 15, 2023

That was added in #1464.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants