Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop all those unnecessary polyfills #10

Closed
SukkaW opened this issue Jul 2, 2023 · 1 comment · Fixed by #11
Closed

Drop all those unnecessary polyfills #10

SukkaW opened this issue Jul 2, 2023 · 1 comment · Fixed by #11

Comments

@SukkaW
Copy link
Collaborator

SukkaW commented Jul 2, 2023

https://github.com/un-es/eslint-plugin-i/blob/616ac75b11731f41a3786bdbe2c7620d65df9ded/package.json#L102-L118

There are WAY TOO MANY polyfills in the dependencies. Let's target Node.js 14 and drop all of them!
@SukkaW
Copy link
Collaborator Author

SukkaW commented Jul 2, 2023 •
edited
Loading

According to https://node.green, even Node.js 12 supports all Array.prototype.includes, Array.prototype.flat, Array.prorotype.flatMap, and Object.values. That's to say, we can drop all of the polyfills if we target Node.js 12.

@SukkaW SukkaW changed the title Drop all those unused polyfills Drop all those unnecessary polyfills Jul 2, 2023
@SukkaW SukkaW mentioned this issue Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@SukkaW