Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work with tags #5

Closed
judoole opened this issue Apr 2, 2020 · 1 comment
Closed

Doesn't work with tags #5

judoole opened this issue Apr 2, 2020 · 1 comment
Assignees
@judoole
Labels
bug Something isn't working

Comments

@judoole
Copy link
Member

judoole commented Apr 2, 2020

This

brokkr/brokkr/brokkr.mk

Line 26 in c4b1281

plugin_version=`echo $@ | rev | cut -d '-' -f 1 | rev | cut -d '.' -f 1`;\
line fails if one uses a tag instead of sha1 or branch.

Fix it, or better, rewrite it to something that is more maintainable. It should be relatable to #3
@judoole judoole added the bug Something isn't working label Apr 2, 2020
@judoole judoole self-assigned this Apr 2, 2020
@judoole
Copy link
Member Author

judoole commented Jun 10, 2020

Fixed in newer versions

@judoole judoole closed this as completed Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@judoole judoole

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@judoole