From 94069b3f2ffe39d3995058d6b31012b13b705b36 Mon Sep 17 00:00:00 2001 From: undergroundwires Date: Fri, 11 Oct 2024 14:10:19 +0200 Subject: [PATCH] Fix CI/CD fail by install ImageMagick on runners This commit addresses an issue where CI/CD jobs fail due to the removal of `imagemagick` from GitHub's preinstalled software list for Ubuntu runners. As a result, commands relying on `imagemagick` were not found. To resolve this, the commit installs `imagemagick` across all platforms (Linux, macOS, and Windows). This safeguards against future changes to the preinstalled software list on GitHub runners. --- .github/workflows/checks.scripts.yaml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/checks.scripts.yaml b/.github/workflows/checks.scripts.yaml index 45cd425c..80d213f4 100644 --- a/.github/workflows/checks.scripts.yaml +++ b/.github/workflows/checks.scripts.yaml @@ -6,19 +6,24 @@ on: jobs: icons-build: - runs-on: ${{ matrix.os }}-latest + runs-on: ${{ matrix.os.name }}-latest strategy: matrix: - os: [ macos, ubuntu, windows ] + os: + - name: macos + install-imagemagick-command: brew install imagemagick + - name: ubuntu + install-imagemagick-command: sudo apt install -y imagemagick + - name: windows + install-imagemagick-command: choco install -y imagemagick fail-fast: false # Still interested to see results from other combinations steps: - name: Checkout uses: actions/checkout@v4 - - name: Install ImageMagick on macOS - if: matrix.os == 'macos' - run: brew install imagemagick + name: Install ImageMagick + run: ${{ matrix.os.install-imagemagick-command }} - name: Setup node uses: ./.github/actions/setup-node