Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge tN Verse Files to Chunks for tS API #44

Open
2 tasks done
jag3773 opened this issue Dec 6, 2017 · 7 comments
Open
2 tasks done

Merge tN Verse Files to Chunks for tS API #44

jag3773 opened this issue Dec 6, 2017 · 7 comments
Assignees

Comments

@jag3773
Copy link
Contributor

jag3773 commented Dec 6, 2017

For the tS v2 API endpoint we want the tN to be presented as chunks, not as individual verses.

The tN will be converted to be verse by verse files in DCS shortly. After that happens we'll need a processor to combine those to be chunk level for the tS v2 API endpoint.

Take note that the processor will need to:

  • Not overwrite the tw_cat.json (see Freeze tw_cat in tS v2 catalog #42 )
  • Condense duplicate notes to 1 per chunk. For example, if chunk 1 contains verses 1-3 and verses 1 and 2 have the exact same note, only include that note once in chunk 1.

The output for the tS v2 API JSON files should so very few (if any) differences to what was published for v11.

@jag3773 jag3773 added the blocked label Dec 6, 2017
@da1nerd
Copy link
Contributor

da1nerd commented Dec 6, 2017

@jag3773 fyi before we make this content change I'll need to disable overwriting tw_cat.json.
Technically this entire issue should be completed before then, but we at least want to disable overwriting the tw_cat.json.

@jag3773
Copy link
Contributor Author

jag3773 commented Dec 12, 2017

Example new structure is https://git.door43.org/destatez/en_tn .

@da1nerd
Copy link
Contributor

da1nerd commented Dec 15, 2017

I think I have this all done. I'm testing rebuilding the ts api to ensure it's backwards compatible with the legacy formatted tN (it works in the unit tests just making sure).

@da1nerd
Copy link
Contributor

da1nerd commented Dec 15, 2017

@jag3773 We are ready for a live test. Can you please submit the updated English Titus tN to the catalog?
All of my tests pass, but just to be safe I've also backed up the notes and tw_cat for Titus in the tS api.

@jag3773 jag3773 self-assigned this Dec 19, 2017
@jag3773
Copy link
Contributor Author

jag3773 commented Dec 19, 2017

@neutrinog It's not going to be until January at the earliest that we want to push a new copy out into the API. Until then do we have a test/dev pipeline that we could it with? If not we can probably wait if that works for you.

@da1nerd
Copy link
Contributor

da1nerd commented Dec 19, 2017

we can wait. I've written a bunch of unit tests regarding this so I feel pretty confident.

@jag3773
Copy link
Contributor Author

jag3773 commented Jan 10, 2018

I want to keep this open a placeholder for us (at least me) to remember that we haven't tested this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants