Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tS catalog processory affecting links to tA? #64

Open
jag3773 opened this issue Oct 30, 2019 · 4 comments
Open

tS catalog processory affecting links to tA? #64

jag3773 opened this issue Oct 30, 2019 · 4 comments
Assignees

Comments

@jag3773
Copy link
Contributor

jag3773 commented Oct 30, 2019

Somehow, it appears that the tS catalog processor is affecting at least some of the links to tA from other resources.

This was noticed in Croatian (hr) resources.

You can see the source tN file here: https://git.door43.org/Door43-Catalog/hr_tn/raw/branch/master/mat/04/07.md . In particular, this note:

Opet, pisano je

Podrazumijeva se da Isus opet citira Sveto Pismo. Ovo se može izreći u aktivnom obliku. AT: "Opet ću ti reći što je Mojsije napisao u Pismu" (Vidi: [[rc://hr/ta/man/translate/figs-activepassive]] i [[rc://hr/ta/man/translate/figs-ellipsis]])

Those tA links look perfect (to me), but in the processed notes JSON they get corrupted, see https://cdn.door43.org/v2/ts/mat/hr/notes.json?date_modified=20191011 :

"Podrazumijeva se da Isus opet citira Sveto Pismo. Ovo se može izreći u aktivnom obliku. AT: "Opet ću ti reći što je Mojsije napisao u Pismu" (Vidi: [[:hr:ta:vol2:translate:figs_activepassive]] i [[:hr:ta:vol2:translate:figs_ellipsis]])"

Or, maybe this conversion is supposed to happen in the notes and words but some sort of transformation is not happening to the Croatian tA? I'm wondering if this was a hack created to make the links point backward to the previous link target locations?

@da1nerd
Copy link
Contributor

da1nerd commented Oct 31, 2019

That is a backwards compatibility conversion. In the tS api all of the tA links get converted to the old dokuwiki link format. This is not something we should change, but instead, if people want to use the newer links they should use the v3 api.

@jag3773
Copy link
Contributor Author

jag3773 commented Oct 31, 2019

OK, I thought that may be what was going on.

However, the issue still remains. The links do not work for Croatian. I do see that links are working in English and Kannada, so I don't know what's missing here.

@da1nerd
Copy link
Contributor

da1nerd commented Nov 1, 2019

ah ok. the english is in TSV format and the croatian is in the original markdown format but only the markdown is converted to the legacy format.

@da1nerd
Copy link
Contributor

da1nerd commented Nov 1, 2019

I installed version ts-android v9.0 (released 3 years ago) and the legacy tA links don't work there either. So I'm going to go ahead and keep all the tA links as RC links in the api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants