Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Link to TA should also be in Note" error in TN validation #191

Closed
birchamp opened this issue Aug 16, 2023 · 2 comments
Closed

Remove "Link to TA should also be in Note" error in TN validation #191

birchamp opened this issue Aug 16, 2023 · 2 comments

Comments

@birchamp
Copy link
Collaborator

It used to be required that a Translation Note should have the link in both the note column and a link in the reference column but that is no longer the case.

The error 787 "Link to TA should also be in Note" should be removed from the validator.

@mandolyte
Copy link
Collaborator

Change needs to be made in this area:
https://github.com/unfoldingWord/gateway-admin/blob/develop/src/utils/contentValidation.js#L83

@birchamp NOTE! this change will not impact any other app using content validation. The logic to filter results wasn't done in the CV RCL originally, so each app using CV has its own filter. At present, I think only tc-create would need to be changed to match this.

Of course, with more effort, this could be moved to CV itself. However, that would be extra work. Updating the filter is fairly trivial (see line reference above)

Hope to make this change later this week.

@mandolyte mandolyte mentioned this issue Sep 25, 2023
2 tasks
@elsylambert
Copy link

The latest develop https://develop--gateway-admin.netlify.app/ looks good with changes to tN content validation where we are no longer seeing error 787 "Link to TA should also be in Note".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants