Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting breaking with Hebrew punctuation in verse ranges #1580

Closed
elsylambert opened this issue May 25, 2023 · 4 comments
Closed

Highlighting breaking with Hebrew punctuation in verse ranges #1580

elsylambert opened this issue May 25, 2023 · 4 comments
Assignees
@jincypjose
Labels
Field Reported This issue was reported from the field QA/DanielTested QA/ElsyTested QA/Passed QA Completed

Comments

@elsylambert
Copy link
Contributor

In Deuteronomy 1:5-6, the quote was not highlighted, so I added an & in the quote and it highlighted the first quote.
image.png
@elsylambert elsylambert added the Field Reported This issue was reported from the field label May 25, 2023
@abelpz
Copy link
Member

abelpz commented May 31, 2023 •
edited
Loading

The problem with this one is that the order for the ampersand separated quotes is not right to left as you would expect for hebrew. It is actually the first quote must be on the left side, and the further quote must be on the right side.

Changing that quote to this: יְהוָ֧ה אֱלֹהֵ֛י⁠נוּ דִּבֶּ֥ר אֵלֵ֖י⁠נוּ בְּ⁠חֹרֵ֣ב & מֹשֶׁ֔ה בֵּאֵ֛ר אֶת־הַ⁠תּוֹרָ֥ה הַ⁠זֹּ֖את לֵ⁠אמֹֽר׃

Would actually highlight what was intended.

@abelpz
Copy link
Member

abelpz commented May 31, 2023

We still have to test the above in tC @jincypjose

@abelpz abelpz mentioned this issue Jun 2, 2023
Merged
@abelpz abelpz linked a pull request Jun 3, 2023 that will close this issue
Bugfix abelpz 1577 1580 #1584
Merged
@abelpz abelpz removed a link to a pull request Jun 3, 2023
Bugfix abelpz 1577 1580 #1584
Merged
@elsylambert
Copy link
Contributor Author

elsylambert commented Jun 5, 2023 •
edited
Loading

Looks good and works fine in translationCore Create - v1.12 build 260-45d04f9
Screenshot 2023-06-05 at 9.40.26 AM.png

Screenshot 2023-06-05 at 9.49.13 AM.png

@danielklapp
Copy link

Highlighting working properly in translationCore Create - v1.12 build 260-45d04f9.

Screenshot 2023-06-06 at 12 26 01 PM

@elsylambert elsylambert reopened this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jincypjose jincypjose

Labels
Field Reported This issue was reported from the field QA/DanielTested QA/ElsyTested QA/Passed QA Completed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@abelpz @elsylambert @jincypjose @danielklapp