Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting for C++ code #234

Open
echeran opened this issue May 23, 2024 · 4 comments
Open

Add linting for C++ code #234

echeran opened this issue May 23, 2024 · 4 comments
Assignees

Comments

@echeran
Copy link
Collaborator

echeran commented May 23, 2024

We should add a C++ linter, as #228 suggests. According to #228 (comment), the industry standard is clang-tidy.

We should ensure that the dependencies for this are in our setup script, and that we add this to CI (or our end-to-end script in CI).

@sffc sffc added this to the 2024 Q3 ⟨P1⟩ milestone Jun 3, 2024
@sven-oly sven-oly self-assigned this Sep 20, 2024
@sven-oly
Copy link
Collaborator

What about this GItHub action? https://github.com/HorstBaerbel/action-clang-tidy

@sven-oly
Copy link
Collaborator

Applying this command fixes some things:
clang-tidy --checks='modernize*, readability*' *.cpp --fix-errors

@sven-oly
Copy link
Collaborator

Does this mean we would apply C++ linting in the continuous integration?

@sffc
Copy link
Member

sffc commented Oct 28, 2024

Yes, we should enforce the C++ linting in GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants