Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trailing whitespace for complex messages #812

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

eemeli
Copy link
Collaborator

@eemeli eemeli commented Jul 1, 2024

Fix for a part of #809, CC @lucacasonato

When parsing a complex message, we should be lenient about trailing whitespace, and silently ignore it. It has no meaning, and should not be considered an error.

None of the parser complexity concerns around leading whitespace apply here.

@eemeli eemeli added syntax Issues related with MF Syntax Agenda+ Requested for upcoming teleconference labels Jul 1, 2024
Copy link
Contributor

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but I think we should also do leading whitespace. From my implementation experience, this is a trivial to implement and can be implemented to be as fast as the current spec behavior.

@eemeli
Copy link
Collaborator Author

eemeli commented Jul 1, 2024

This is good, but I think we should also do leading whitespace. From my implementation experience, this is a trivial to implement and can be implemented to be as fast as the current spec behavior.

I completely agree, but I'd like to ensure that we at least get trailing whitespace rather than having this blocked by implementation or other concerns about mode detection with leading whitespace.

spec/syntax.md Outdated Show resolved Hide resolved
@aphillips aphillips added normative LDML46 LDML46 Release (Tech Preview - October 2024) labels Jul 1, 2024
@eemeli eemeli merged commit 661edfb into main Jul 8, 2024
2 checks passed
@eemeli eemeli deleted the allow-trailing-spaces branch July 8, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agenda+ Requested for upcoming teleconference LDML46 LDML46 Release (Tech Preview - October 2024) normative syntax Issues related with MF Syntax
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants