Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine error handling text #816

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Refine error handling text #816

merged 5 commits into from
Aug 26, 2024

Conversation

eemeli
Copy link
Collaborator

@eemeli eemeli commented Jul 8, 2024

Updates to the spec that implement the design doc introduced in #804.

Filed initially as a draft pending the previously discussed updates to the design doc, but happy to accept reviews and recommendations for the text already.

@eemeli eemeli added normative formatting errors Issues related to the errors section of the spec labels Jul 8, 2024
spec/errors.md Outdated Show resolved Hide resolved
spec/errors.md Outdated Show resolved Hide resolved
spec/errors.md Outdated Show resolved Hide resolved
Co-authored-by: Addison Phillips <[email protected]>
spec/errors.md Outdated Show resolved Hide resolved
@eemeli
Copy link
Collaborator Author

eemeli commented Jul 29, 2024

I merged the fallback text suggestion from #816 (comment), as it's at least a step forwards, and turned the two-item list into two separate paragraphs instead.

@eemeli eemeli requested a review from aphillips July 29, 2024 10:22
Copy link
Member

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Minor comment about one of the normative statements keeps me from approving.

spec/errors.md Outdated Show resolved Hide resolved
Co-authored-by: Addison Phillips <[email protected]>
@eemeli eemeli requested a review from aphillips July 29, 2024 16:21
@aphillips aphillips merged commit 14fd7b5 into main Aug 26, 2024
1 check passed
@aphillips aphillips deleted the refine-errors branch August 26, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues related to the errors section of the spec formatting normative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants