Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bidi support and address UAX31/UTS55 requirements #884

Merged
merged 28 commits into from
Sep 16, 2024
Merged

Add bidi support and address UAX31/UTS55 requirements #884

merged 28 commits into from
Sep 16, 2024

Commits on Sep 11, 2024

  1. Add bidi support and address UAX31/UTS55 requirements 

    Adds the bidi strong marks ALM, RLM, and LRM plus the bidi isolate controls LRI, RLI, FSI, and PDI to the syntax.

Formally defines optional vs. non-optional whitespace.

Non-optional whitespace must include at least one whitespace character. Optional whitespace may contain only bidi marks (which are invisible)
    @aphillips
    aphillips committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    82fcef3 View commit details
    Browse the repository at this point in the history

  2. Update syntax.md including text from previous PR

    @aphillips
    aphillips committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c5baba6 View commit details
    Browse the repository at this point in the history

  3. Repair the guidance on strongly directional marks 

    Include ALM and better specify how to use the marks.
    @aphillips
    aphillips committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ca63819 View commit details
    Browse the repository at this point in the history

  4. Fix formatting of the "important"

    @aphillips
    aphillips committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1e172fd View commit details
    Browse the repository at this point in the history

  5. Add bidi characters to description of whitespace.

    @aphillips
    aphillips committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    afd5ef0 View commit details
    Browse the repository at this point in the history

  6. Permit bidi in a few more places 

    Add optional whitespace at the start of `variant`

Add optional whitespace around `quoted-pattern`

These changes result in allowing bidi around keys and quoted patterns as intended.
    @aphillips
    aphillips committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c7a41fc View commit details
    Browse the repository at this point in the history

  7. Update syntax.md ABNF

    @aphillips
    aphillips committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b0cd0a5 View commit details
    Browse the repository at this point in the history

  8. Update formatting.md 

    - Add a note about the difference between formatting and message syntax.
- Clarify the sentence about message directionality.
    @aphillips
    aphillips committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    cacc5e9 View commit details
    Browse the repository at this point in the history

  9. Address comment about name/identifier

    @aphillips
    aphillips committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1fb0f92 View commit details
    Browse the repository at this point in the history

  10. Address comments related to bidi in name

    @aphillips
    aphillips committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a79fb8d View commit details
    Browse the repository at this point in the history

  11. Fix variable's location

    @aphillips
    aphillips committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    86a20f8 View commit details
    Browse the repository at this point in the history

  12. Address comment about the list of LRI/PDI targets

    @aphillips
    aphillips committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    768a8a8 View commit details
    Browse the repository at this point in the history

  13. One character typo :-P

    @aphillips
    aphillips committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    fd9fc57 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Update spec/syntax.md 

    Co-authored-by: Eemeli Aro <[email protected]>
    @aphillips @eemeli
    aphillips and eemeli committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    734ef49 View commit details
    Browse the repository at this point in the history

  2. Address comments about rule R3a-1

    @aphillips
    aphillips committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4541758 View commit details
    Browse the repository at this point in the history

  3. Update spec/syntax.md 

    Co-authored-by: Eemeli Aro <[email protected]>
    @aphillips @eemeli
    aphillips and eemeli committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d751181 View commit details
    Browse the repository at this point in the history

  4. Address comment about U+061C

    @aphillips
    aphillips committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    cbd0457 View commit details
    Browse the repository at this point in the history

  5. Change [o]wsp => o or s

    @aphillips
    aphillips committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0df963e View commit details
    Browse the repository at this point in the history

  6. Match syntax spec to abnf

    @aphillips
    aphillips committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    be8fa43 View commit details
    Browse the repository at this point in the history

  7. Remove *

    @aphillips
    aphillips committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f110af7 View commit details
    Browse the repository at this point in the history

  8. Update syntax.md

    @aphillips
    aphillips committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d8c6d0f View commit details
    Browse the repository at this point in the history

  9. Update spec/syntax.md 

    Co-authored-by: Eemeli Aro <[email protected]>
    @aphillips @eemeli
    aphillips and eemeli committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d5fb3bb View commit details
    Browse the repository at this point in the history

  10. Update spec/message.abnf 

    Co-authored-by: Eemeli Aro <[email protected]>
    @aphillips @eemeli
    aphillips and eemeli committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    82af41f View commit details
    Browse the repository at this point in the history

  11. Update spec/message.abnf 

    Co-authored-by: Eemeli Aro <[email protected]>
    @aphillips @eemeli
    aphillips and eemeli committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d9d79bc View commit details
    Browse the repository at this point in the history

  12. Update syntax.md

    @aphillips
    aphillips committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7858961 View commit details
    Browse the repository at this point in the history

  13. Update spec/message.abnf 

    Co-authored-by: Eemeli Aro <[email protected]>
    @aphillips @eemeli
    aphillips and eemeli committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e7aa24c View commit details
    Browse the repository at this point in the history

  14. Update spec/syntax.md 

    Co-authored-by: Eemeli Aro <[email protected]>
    @aphillips @eemeli
    aphillips and eemeli committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    86fc1d4 View commit details
    Browse the repository at this point in the history

  15. Update spec/syntax.md 

    Co-authored-by: Eemeli Aro <[email protected]>
    @aphillips @eemeli
    aphillips and eemeli committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d5303c2 View commit details
    Browse the repository at this point in the history