New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with dump file when using divisions for component state #32

Closed

ThibHlln opened this issue Apr 13, 2021 · 0 comments · Fixed by #33

Assignees

Labels

bug

Member

ThibHlln commented Apr 13, 2021 •

edited

Loading

The "divisions" key of _states_info is correctly used to allocate memory,
https://github.com/hydro-jules/cm4twc/blob/27deb9b9c95d968b980447865fb809c2d8f88800/cm4twc/components/component.py#L761-L773

but it is not used when creating the dumps for the states
https://github.com/hydro-jules/cm4twc/blob/27deb9b9c95d968b980447865fb809c2d8f88800/cm4twc/components/_utils/states.py#L120-L125

resulting in a broadcasting error when trying to update the dumps with state arrays
https://github.com/hydro-jules/cm4twc/blob/27deb9b9c95d968b980447865fb809c2d8f88800/cm4twc/components/_utils/states.py#L142

This needs to be fixed in create_states_dump.

The text was updated successfully, but these errors were encountered:

ThibHlln added the bug label

ThibHlln self-assigned this

ThibHlln mentioned this issue

add netCDF dimension for component state divisions in dump file #33

Merged

ThibHlln linked a pull request

that will close this issue

add netCDF dimension for component state divisions in dump file #33

Merged

ThibHlln closed this as completed

ThibHlln mentioned this issue

Release v0.1.0 #79

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment