Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Model identifier renaming not propagating to its components #48

Closed
ThibHlln opened this issue Jul 9, 2021 · 0 comments
Closed

Fix Model identifier renaming not propagating to its components #48

ThibHlln opened this issue Jul 9, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ThibHlln
Copy link
Member

ThibHlln commented Jul 9, 2021

identifier is currently propagated down to its components at instantiation. Yet, identifier can be changed to a different value after instantiation. Changing the identifier should remain a possibility as this is useful e.g. after an instantiation through the constructor method from_yaml() where the user is reusing a previous configuration, tweaking it to their liking, and starting a new simulation with it.

The impact of this bug is that only model files are impacted by the renaming, not its components' files, which can result in some dangerous silent overwriting of existing simulation outputs.

So identifier needs to become a property of Model, and its setter needs to propagate the identifier to its components in addition to renaming itself.

@ThibHlln ThibHlln added the bug Something isn't working label Jul 9, 2021
@ThibHlln ThibHlln self-assigned this Jul 9, 2021
@ThibHlln ThibHlln changed the title Fix model identifier renaming not propagating to its components Fix Model identifier renaming not propagating to its components Jul 9, 2021
@ThibHlln ThibHlln mentioned this issue Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant