Fix Model
identifier renaming not propagating to its components
#48
Labels
bug
Something isn't working
Model
identifier renaming not propagating to its components
#48
identifier is currently propagated down to its components at instantiation. Yet, identifier can be changed to a different value after instantiation. Changing the identifier should remain a possibility as this is useful e.g. after an instantiation through the constructor method
from_yaml()
where the user is reusing a previous configuration, tweaking it to their liking, and starting a new simulation with it.The impact of this bug is that only model files are impacted by the renaming, not its components' files, which can result in some dangerous silent overwriting of existing simulation outputs.
So identifier needs to become a property of
Model
, and its setter needs to propagate the identifier to its components in addition to renaming itself.The text was updated successfully, but these errors were encountered: