Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up class initialization methods using methods instead of hash setters #6

Open
ronaldtse opened this issue Dec 29, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@ronaldtse
Copy link

e.g.

def initialize(id, hash)
begin
@id = id
@dimension = hash["dimension_url"].sub(/^#/, "")
@type = hash["quantity_type"]
hash["quantity_name"] and @names = hash["quantity_name"]
@units = serialize_units(hash["unit_reference"])
# rescue
# raise StandardError.new "Parse fail on Quantity #{id}: #{hash}"
end
end

@ronaldtse ronaldtse added the enhancement New feature or request label Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant