Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser ignores httponly attribute #17

Closed
tobiasdiez opened this issue Sep 23, 2023 · 1 comment
Closed

Parser ignores httponly attribute #17

tobiasdiez opened this issue Sep 23, 2023 · 1 comment

Comments

@tobiasdiez
Copy link

tobiasdiez commented Sep 23, 2023

Environment

v.1.0.0

Reproduction

No repo

Describe the bug

Running parse on session=xyz; Path=/; Expires=Sun, 24 Mar 2024 09:13:27 GMT; HttpOnly; SameSite=Strict yields

{
  session: 'xyz',
  Path: '/',
  Expires: 'Sun, 24 Mar 2024 09:13:27 GMT',
  SameSite: 'Strict'
} 

without the httponly attribute

Additional context

Upstream issue is jshttp/cookie#115. Apparently, the parser only supports the cookie header of the request, not the set-cookie header of a response...

Code of unjs/nitro#1753 can be reused for this purpose.

Logs

No response

@pi0
Copy link
Member

pi0 commented May 22, 2024

Hi. Currently this lib is intended for parsing Cookie header which has not single value. I've made a proposal for supporting it ~> #33

@pi0 pi0 closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants