Wrong typing for readRawBody

[P4sca1]

readRawBody is meant to return a Buffer when encoding is set to false, but it always returns Promise<string | Buffer | undefined>. The reason is that Encoding extends false always returns false. The function likely needs a generic type parameter. Also, looking at the source code, the function seems to always return a Promise, and never returns a Buffer when encoding is set.

h3/src/utils/body.ts

Line 18 in f78778c

export function readRawBody (event: H3Event, encoding: Encoding = 'utf-8'): Encoding extends false ? Buffer : Promise<string | Buffer | undefined> {

The following type declaration should be correct

declare function readRawBody<E extends Encoding | false = 'utf-8'>(event: H3Event, encoding?: E): E extends false ? Promise<Buffer> : Promise<string | undefined>;

[pi0]

/cc @danielroe