Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing blankline from title to description when coming from $schema #70

Closed
atinux opened this issue Jan 13, 2023 · 5 comments
Closed

Missing blankline from title to description when coming from $schema #70

atinux opened this issue Jan 13, 2023 · 5 comments

Comments

@atinux
Copy link
Member

atinux commented Jan 13, 2023

Environment

Latest version

Reproduction

https://untyped.unjs.io/#eyJlZGl0b3JUYWIiOiJyZWZlcmVuY2UiLCJvdXRwdXRUYWIiOiJ0eXBlcyIsInJlZiI6Ii8qKiBAdW50eXBlZCAqL1xuZXhwb3J0IGZ1bmN0aW9uIHNlbmRNZXNzYWdlIChtZXNzYWdlOiBzdHJpbmcsIGRhdGUgPSBuZXcgRGF0ZSgpLCBmbGFzaD86IGJvb2xlYW4pOiBzdHJpbmcge1xuICByZXR1cm4gJ09LJ1xufVxuXG5leHBvcnQgY29uc3QgY29uZmlnID0ge1xuICAgIG51eHRJY29uOiB7XG4gICAgICAgICRzY2hlbWE6IHtcbiAgICAgICAgICAgIHRpdGxlOiAnTnV4dCBJY29uJyxcbiAgICAgICAgICAgIGRlc2NyaXB0aW9uOiAnQ29uZmlndXJlIHRoZSBkZWZhdWx0cyBvZiBOdXh0IEljb24nXG4gICAgICAgIH1cbiAgICB9XG59IiwiaW5wdXQiOiJleHBvcnQgY29uc3QgY29uZmlnID0ge1xuICAgIG5hbWU6ICdmb28nLFxuICAgIGRpbWVuc2lvbnM6IHtcbiAgICAgICAgaGVpZ2h0OiAyNVxuICAgIH0sXG4gICAgdGFnczogWydjdXN0b20nXVxufSJ9

Describe the bug

CleanShot 2023-01-13 at 17 46 09@2x

Because we miss the blankline, it renders like this:

CleanShot 2023-01-13 at 17 48 37@2x

Instead of:
CleanShot 2023-01-13 at 17 49 17@2x

Additional context

No response

Logs

No response
@pi0
Copy link
Member

pi0 commented Jan 13, 2023

Issue is that, we intentionally strip empty (+1) lines from description but probably we can add them between all final description before generation 👍🏼

@atinux Volta.net
Copy link
Member Author

atinux commented Jan 13, 2023

It would be great indeed, that will improve the DX of Nuxt Icon auto complete

@pi0 pi0 closed this as completed in 5255259 Jan 13, 2023
@pi0
Copy link
Member

pi0 commented Jan 13, 2023

Pushed a fix. Can you plese double check on playground before release?

@atinux Volta.net
Copy link
Member Author

atinux commented Jan 13, 2023

Looks good on the playground:
CleanShot 2023-01-13 at 18.05.06@2x.png

@atinux Volta.net
Copy link
Member Author

atinux commented Jan 13, 2023

Happy to push a release for me to try on Nuxt Icon @pi0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atinux @pi0