Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MVUX] Update Bindable Generator Attribute Naming #2515

Open
6 tasks
ajpinedam opened this issue Aug 20, 2024 · 2 comments
Open
6 tasks

[MVUX] Update Bindable Generator Attribute Naming #2515

ajpinedam opened this issue Aug 20, 2024 · 2 comments
Assignees
@ajpinedam
Labels
kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification.

Comments

@ajpinedam
Copy link
Contributor

What would you like to be added:

Rename the Bindable Generator Attribute to something more generic, especially now that this is not generating BindableModels anymore but instead it is generating ViewModels

Why is this needed:

For which Platform:

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renders for Xamarin.Forms
  • Windows
  • Build tasks

Anything else we need to know?
@ajpinedam ajpinedam added kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification. labels Aug 20, 2024
@ajpinedam ajpinedam self-assigned this Aug 20, 2024
@dr1rrb
Copy link
Member

dr1rrb commented Aug 20, 2024

Considering that the BindableAttribute is the attribute used by windows to flag object that should be accessible to the binding engine, I would not introduce a breaking change to rename those attributes.

@francoistanguay
Copy link
Contributor

Didnt realize BindableGenerator was "associated" to the BindableAttribute idea. Happy to keep it as-is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajpinedam ajpinedam

Labels
kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ajpinedam @dr1rrb @francoistanguay