Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise Xamarin.AndroidX.Legacy.Support.V4 dependency #14209

Closed
Youssef1313 opened this issue Oct 31, 2023 · 3 comments · Fixed by #14247
Closed

Revise Xamarin.AndroidX.Legacy.Support.V4 dependency #14209

Youssef1313 opened this issue Oct 31, 2023 · 3 comments · Fixed by #14247
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers kind/enhancement New feature or request platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Oct 31, 2023 •
edited
Loading

What would you like to be added

I'm not sure if we really need this dependency.

Why is this needed

See dotnet/maui#12232 where this change has improved app size.

For which platform

No response

Anything else we need to know?

No response
@Youssef1313 Youssef1313 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Oct 31, 2023
@MartinZikmund MartinZikmund added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Nov 2, 2023
@jeromelaban
Copy link
Member

It is likely that we don't, and we could remove it from net8.

@Youssef1313
Copy link
Member Author

@jeromelaban Only net8.0? Do we need it for net7.0?

@jeromelaban
Copy link
Member

The problem of modifying net7 is that it would cause a break in the dependency chain for projects that is not necessary. Changing in net8 only makes it clear that the upgrade requires that change, and it's not too late to do that I think.

@Youssef1313 Youssef1313 mentioned this issue Nov 2, 2023
Merged
6 tasks
@MagicAndre1981 MagicAndre1981 mentioned this issue Dec 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers kind/enhancement New feature or request platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: Remove Xamarin.AndroidX.Legacy.Support.v4 on net8.0 Youssef1313/uno
3 participants
@MartinZikmund @jeromelaban @Youssef1313