Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull down to close not working when form is inside the DrawerContent #25

Open
BayBreezy opened this issue Feb 26, 2024 · 3 comments
Open
Labels
bug Something isn't working

Comments

@BayBreezy
Copy link

Hello again,

I added a little demo of how to use the drawer component here: https://ui-thing.behonbaker.com/components/drawer#usage

I noticed that when I added a form to the DrawerContent, the ability to pull down and close the drawer only happens once.

If I open the drawer a second time without leaving the page(unmounting the component), then the functionality to pull down and close does not work.

Maybe I am doing something wrong?

@Elliot-Alexander Elliot-Alexander added the bug Something isn't working label Mar 2, 2024
@Elliot-Alexander
Copy link
Collaborator

Hey!
Can you try with the latest version and see if the issue still persists? Should hopefully have been solved in the refactor.
Otherwise happy to investigate further :D

@BayBreezy
Copy link
Author

Hey @Elliot-Alexander ,

Even after updating, I am not seeing where the behaviour changed. i will add another example soon showing it working when the form is not present.

@BayBreezy
Copy link
Author

@Elliot-Alexander So on this page: https://ui-thing.behonbaker.com/components/drawer#with-image
You see the image can be pulled down multiple times but the form can only be pulled down once. You have to remount the form on for it to work as normal once again.
So for the form, you have to switch to the code tab and back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants