Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tabsCss property #187

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

henrymyers
Copy link
Contributor

Description

The file uploader currently supports passing in custom CSS for iframe tabs (e.g. Instagram, Facebook, etc), yet I didn't see any clear way of doing so through react-widget. This can now be accomplished for both the Widget and Dialog components via the tabsCss property. The value passed in can be either a CSS string or an absolute file URL.

// Via URL
<Widget tabs="facebook" tabsCss="https://site.com/styles/uc.tabs.css"/>

// Via plain CSS
<Widget tabs="facebook" tabsCss=".source-facebook { background: #1877F2; }"/>

Resulting widget
Screen Shot 2020-07-23 at 4 48 10 PM

Checklist

@jeetiss
Copy link
Contributor

jeetiss commented Jul 27, 2020

thank you for the PR!

@jeetiss jeetiss merged commit 158602b into uploadcare:master Jul 27, 2020
@henrymyers henrymyers deleted the feat/tabs-css-support branch July 27, 2020 13:04
@henrymyers
Copy link
Contributor Author

My pleasure! Would it be possible to bump the version and publish soon so I can access this new feature without pointing to my fork?

@jeetiss
Copy link
Contributor

jeetiss commented Jul 27, 2020

yes of course

@jeetiss
Copy link
Contributor

jeetiss commented Jul 27, 2020

@shipjs prepare

@github-actions
Copy link
Contributor

@jeetiss shipjs prepare done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants