Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong onFileSelect typings and readme info #201

Closed
lxsmnsyc opened this issue Aug 23, 2020 · 4 comments · Fixed by #204
Closed

Wrong onFileSelect typings and readme info #201

lxsmnsyc opened this issue Aug 23, 2020 · 4 comments · Fixed by #204
Assignees
@jeetiss
Labels
bug

Comments

@lxsmnsyc
Copy link

In the File Uploader API doc, the file you receive in the onChange event has the methods progress and done, in contrast, the onChange of the React widget only gives you the FileInfo interface but without the progress and done. Is there a way to access these? It would be useful for presenting the progress or loading UI whenever an upload is being processed.
@lxsmnsyc lxsmnsyc added the question Further information is requested label Aug 23, 2020
@jeetiss
Copy link
Contributor

jeetiss commented Aug 23, 2020

Hello @lxsmnsyc
We have wrong information about this in readme! Please use onFileSelect callback for access to files before upload

example on codesandbox

@lxsmnsyc
Copy link
Author

Thanks for the response.

To add context, we were using Typescript so there is no way for us to access these features unless we redefine the FileInfo interface and the onFileSelect types itself

@jeetiss
Copy link
Contributor

jeetiss commented Aug 23, 2020

I can fix that tomorrow or you can make PR by yourself

@jeetiss jeetiss added bug and removed question Further information is requested labels Aug 23, 2020
@jeetiss jeetiss changed the title Progress and Done methods from FileInfo Wrong onFileSelect typings and readme info Aug 23, 2020
@jeetiss jeetiss mentioned this issue Aug 24, 2020
Merged
3 tasks
@jeetiss
Copy link
Contributor

jeetiss commented Aug 24, 2020

@lxsmnsyc I opened PR with fix. Can you review and approve that everything is okey?

@jeetiss jeetiss self-assigned this Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeetiss jeetiss

Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): improve onFileSelect callback typings uploadcare/react-widget
2 participants
@lxsmnsyc @jeetiss