Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chat function in BaseLLMClient #30

Closed
uripeled2 opened this issue Jul 7, 2023 · 0 comments · Fixed by #31
Closed

Add chat function in BaseLLMClient #30

uripeled2 opened this issue Jul 7, 2023 · 0 comments · Fixed by #31
Assignees
Labels
enhancement New feature or request

Comments

@uripeled2
Copy link
Owner

We can add and abstract method to BaseLLMClient like:
def chat_completion(messages, **kwargs) -> list[str]
We need to implement it in the different clients, we can define a scheme similar to what LangChain did with AIMessage, HumanMessage and SystemMessage
Here is OpenAI docs for this kind of endpoint: https://platform.openai.com/docs/api-reference/chat

@uripeled2 uripeled2 added the enhancement New feature or request label Jul 7, 2023
@uripeled2 uripeled2 self-assigned this Jul 10, 2023
@uripeled2 uripeled2 linked a pull request Jul 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant