From 9e9b5ca27b8db3e717187d616fbac36beb8942bb Mon Sep 17 00:00:00 2001 From: Denis Badurina Date: Thu, 5 Nov 2020 13:33:03 +0100 Subject: [PATCH] (fix) - use Record over object type for subscription operation variables (#1119) * fix: use record over object * docs: changeset --- .changeset/breezy-ghosts-sin.md | 5 +++++ packages/core/src/exchanges/subscription.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/breezy-ghosts-sin.md diff --git a/.changeset/breezy-ghosts-sin.md b/.changeset/breezy-ghosts-sin.md new file mode 100644 index 0000000000..4e41f322e9 --- /dev/null +++ b/.changeset/breezy-ghosts-sin.md @@ -0,0 +1,5 @@ +--- +'@urql/core': patch +--- + +Use `Record` over `object` type for subscription operation variables. The `object` type is currently hard to use ([see this issue](https://github.com/microsoft/TypeScript/issues/21732)). diff --git a/packages/core/src/exchanges/subscription.ts b/packages/core/src/exchanges/subscription.ts index 2b900a11f9..7045896bc2 100644 --- a/packages/core/src/exchanges/subscription.ts +++ b/packages/core/src/exchanges/subscription.ts @@ -38,7 +38,7 @@ export interface ObservableLike { export interface SubscriptionOperation { query: string; - variables?: object; + variables?: Record; key: string; context: OperationContext; }