Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure building/checking depends on Wasm import functions being correct #163

Closed
5 tasks
cmichi opened this issue Jan 27, 2021 · 0 comments · Fixed by #171
Closed
5 tasks

Ensure building/checking depends on Wasm import functions being correct #163

cmichi opened this issue Jan 27, 2021 · 0 comments · Fixed by #171
Assignees
@cmichi
Labels
enhancement New feature or request

Comments

@cmichi
Copy link
Collaborator

cmichi commented Jan 27, 2021

We want to examine the resulting contract Wasm in order to ensure that certain criteria are met.

ToDo

  • Ensure that building/checking happens only if the following conditions are fulfilled.
  • Ensure that only seal_* functions are imported in the resulting contract Wasm.
  • For functions which are not seal_* we want to give helpful messages:
    • Recommend overflow-checks = false when this bug occurs.
    • If generated ink! constructs like this are found.
@cmichi cmichi added the enhancement New feature or request label Jan 27, 2021
@cmichi cmichi self-assigned this Feb 3, 2021
@cmichi cmichi mentioned this issue Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmichi cmichi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Wasm validation for known issues/markers use-ink/cargo-contract
1 participant
@cmichi