Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add save prompt before closing requests using tab context menu #3225

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

rsilvr
Copy link
Contributor

@rsilvr rsilvr commented Sep 29, 2024

Description

In current version of Bruno (1.34.0), when closing a tab of a request with unsaved changes, that request is saved automatically.

In order to follow the behavior of the application when closing a request using the close icon or when trying to close the entire app, which prompts the user if wants to save it or not, I just added the prompt to the tab context menu.

Additional changes

  • Refactor of the save modals (SaveRequestsModal and ConfirmRequestClose) to a single component that is able to handle one or many requests and adapt the message accordingly.
  • "Close Saved" context menu is now disabled if all open tabs have pending changes.
feat-save-prompt.mp4

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Closes #3224

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@rsilvr rsilvr marked this pull request as ready for review September 29, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add save prompt when closing requests from tab context menu
1 participant