Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResValues no longer work in 6.0.0 #382

Closed
brudaswen opened this issue Nov 14, 2022 · 3 comments
Closed

ResValues no longer work in 6.0.0 #382

brudaswen opened this issue Nov 14, 2022 · 3 comments

Comments

@brudaswen
Copy link
Contributor

Using InternalArtifactType.GENERATED_RES has the side-effect, that res values that are created using Gradle are no longer part of the build.

I updated one of the test apps which shows that the String value is no longer used and the build fails:
cd0bb0f

One can also see that AS no longer recognizes the folder as a resource folder:

<6.0.0 6.0.0
image image

I tried to fix the issue, but was not lucky, yet:
c4148d1

@mateuszkwiecinski
Copy link
Member

Thanks for keeping an eye on the plugin 🙏
Your fix looked so much reasonable, it made me test it against AGP 7.4.0-beta05 and 8.0.0-alpha08. Surprise surprise, it seemed to work on them both... 🤷 This makes me believe this is another bug in 7.3.x version: this one looks related: https://issuetracker.google.com/issues/237421684 😞

I came up with my proposal, based on your suggestion: #383.
I wasn't able to figure out "proper" workaround for AGP 7.3.X - it feels like this version is simply flawed and that's all, period :/

@brudaswen
Copy link
Contributor Author

Thanks a lot for maintaining this super useful plugin. 🤗

Strange, I also stumbled upon the Google issue and thought it might cause problems. But even after updating to 7.4beta05, I could not build with the generated icons.

I will test your branch tomorrow, but this looks promising to fix the issue in 7.4. Thanks a lot for the quick help.

@mateuszkwiecinski
Copy link
Member

The workaround has landed in #383 and has been released as 6.1.0, but since AGP 7.4.1 is now available, and it solves almost all the issues (except #408), therfore I'm going to close this one 👀 Thanks again for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants