node-cli image has LAGOON_LOCALDEV_HTTP_PORT

[shreddedbacon]

Because the node-cli image inherits the node image, it exposes the LAGOON_LOCALDEV_HTTP_PORT that HAProxy uses to expose the service locally with Pygmy.

This image probably doesn't need to expose this port because like php-cli it is typically used as a cli container for interacting with the environment and other components in the environment, and not serving traffic.

Since the pygmy haproxy configuration checks for the existence of this variable, simply overriding it by adding ENV LAGOON_LOCALDEV_HTTP_PORT= in a custom dockerfile that inherits from node-cli results in strange behaviour with pygmy and haproxy. Separately, the haproxy configuration should probably check if the variable is set, rather than existing.

Outside of the haproxy issue, it might be worth exploring perhaps an intermediary image called something like node-js that the node and node-cli images can inherit from, and then the LAGOON_LOCALDEV_HTTP_PORT could be exposed only in the node image. This would allow all the core logic of installing node-js to be done in isolation, then all the specific stuff for node and node-cli can be added as required. This limits the impact to users of the existing images.