Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error response to requesting systems that send a non-mtom ITI-41 message #581

Closed
tonesoutherland opened this issue Mar 10, 2023 · 2 comments
Assignees
Milestone

Comments

@tonesoutherland
Copy link

When sending a non-MTOM XDS/XDR ITI-41 request to the simulator a fault exception is returned with a stack trace that does not indicate what the issue is. The XDS simulator tool is behaving correctly since MTOM is required for XD* transactions, however the response needs to be more clear, indicating that the requester is sending a non-MTOM request.

This was discovered testing at the 2023 NA Connectathon in Austin.

See attached files.

ITI-41-non-mtom.txt
ITI-41-non-mtom-fault-exceptoin.txt

@skbhaskarla skbhaskarla added this to the v8.0.0 milestone Mar 10, 2023
@skbhaskarla skbhaskarla removed this from the v8.0.0 milestone Mar 21, 2023
@andrewmccaffreynist
Copy link
Member

Mitigated in BUGFIX/NonMTOMITI41Message581 branch. Xds Toolktit response to message contained in ITI-41-non-mtom.txt is now:

HTTP/1.1 200
Content-Type=multipart/related; boundary=MIMEBoundary112233445566778899; type="application/xop+xml"; start="[email protected]"; start-info="application/soap+xml"
Content-Length=991
Date=Tue, 02 May 2023 14:24:21 GMT
Keep-Alive=timeout=20
Connection=keep-alive

--MIMEBoundary112233445566778899

Content-Type: application/xop+xml; charset=UTF-8; type="application/soap+xml"
Content-Transfer-Encoding: binary
Content-ID: [email protected]

<S:Envelope xmlns:S="http://www.w3.org/2003/05/soap-envelope"><S:Header><wsa:Action xmlns:wsa="http://www.w3.org/2005/08/addressing" xmlns:s="http://www.w3.org/2003/05/soap-envelope" s:mustUnderstand="1">urn:ihe:iti:2007:ProvideAndRegisterDocumentSet-bResponse</wsa:Action><wsa:RelatesTo xmlns:wsa="http://www.w3.org/2005/08/addressing">urn:uuid:55053580-39cc-476f-9d89-31ef1cbb2599</wsa:RelatesTo></S:Header><S:Body><fault:Fault xmlns:fault="http://www.w3.org/2003/05/soap-envelope">fault:Codefault:Valuefault:Sender</fault:Value></fault:Code>fault:Reason<fault:Text xml:lang="en">Header/Format Validation errors reported by HttpMessageValidator

Expected [Multipart] Found [ SIMPLE Format]
</fault:Text></fault:Reason></fault:Fault></S:Body></S:Envelope>

--MIMEBoundary112233445566778899--

@skbhaskarla skbhaskarla added this to the v7.10.0 milestone May 3, 2023
@skbhaskarla
Copy link
Collaborator

BUGFIX/NonMTOMITI41Message581 merged to develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants