From 9e3aa6b40b809f2da672cdb355470be107013de6 Mon Sep 17 00:00:00 2001 From: Christopher Bisom Date: Mon, 21 Oct 2024 11:38:15 -0400 Subject: [PATCH 1/3] 10261-story: fix sealed icon hover text --- .../utilities/getSealedDocketEntryTooltip.ts | 1 + .../computeds/practitionerInformationHelper.ts | 12 +----------- web-client/src/styles/custom.scss | 3 ++- .../views/Practitioners/PractitionerCaseIcons.tsx | 4 ++-- 4 files changed, 6 insertions(+), 14 deletions(-) diff --git a/shared/src/business/utilities/getSealedDocketEntryTooltip.ts b/shared/src/business/utilities/getSealedDocketEntryTooltip.ts index 98221080070..8792be99d2b 100644 --- a/shared/src/business/utilities/getSealedDocketEntryTooltip.ts +++ b/shared/src/business/utilities/getSealedDocketEntryTooltip.ts @@ -1,3 +1,4 @@ +// This applies only to docket entries, not to full cases export const getSealedDocketEntryTooltip = (applicationContext, entry) => { const { DOCKET_ENTRY_SEALED_TO_TYPES } = applicationContext.getConstants(); diff --git a/web-client/src/presenter/computeds/practitionerInformationHelper.ts b/web-client/src/presenter/computeds/practitionerInformationHelper.ts index b7da04a4f7b..82102254920 100644 --- a/web-client/src/presenter/computeds/practitionerInformationHelper.ts +++ b/web-client/src/presenter/computeds/practitionerInformationHelper.ts @@ -5,25 +5,17 @@ import { state } from '@web-client/presenter/app.cerebral'; import { Get } from 'cerebral'; import { PractitionerCaseDetail } from '@web-client/presenter/state'; -import { getSealedDocketEntryTooltip } from '@shared/business/utilities/getSealedDocketEntryTooltip'; const PAGE_SIZE = 100; const getPagesToDisplay = ({ - applicationContext, cases, pageNumber, }: { pageNumber: number; cases: PractitionerCaseDetail[]; - applicationContext: ClientApplicationContext; }) => { - return cases - .slice(pageNumber * PAGE_SIZE, (pageNumber + 1) * PAGE_SIZE) - .map(c => { - c.sealedToTooltip = getSealedDocketEntryTooltip(applicationContext, c); - return c; - }); + return cases.slice(pageNumber * PAGE_SIZE, (pageNumber + 1) * PAGE_SIZE); }; export const practitionerInformationHelper = ( @@ -64,13 +56,11 @@ export const practitionerInformationHelper = ( const showClosedCasesPagination = totalClosedCasesPages > 1; const openCasesToDisplay = getPagesToDisplay({ - applicationContext, cases: practitionerDetail.openCaseInfo?.allCases || [], pageNumber: practitionerDetail.openCaseInfo?.currentPage || 0, }); const closedCasesToDisplay = getPagesToDisplay({ - applicationContext, cases: practitionerDetail.closedCaseInfo?.allCases || [], pageNumber: practitionerDetail.closedCaseInfo?.currentPage || 0, }); diff --git a/web-client/src/styles/custom.scss b/web-client/src/styles/custom.scss index 0cd284e2cc0..cc9d1cc80cb 100644 --- a/web-client/src/styles/custom.scss +++ b/web-client/src/styles/custom.scss @@ -1794,7 +1794,8 @@ button.change-scanner-button { margin-right: 4px; } -.sealed-docket-entry { +.sealed-docket-entry, +.sealed-case-entry { color: color($theme-color-secondary-dark); } diff --git a/web-client/src/views/Practitioners/PractitionerCaseIcons.tsx b/web-client/src/views/Practitioners/PractitionerCaseIcons.tsx index cd9e2950d9f..e5ab7b1914b 100644 --- a/web-client/src/views/Practitioners/PractitionerCaseIcons.tsx +++ b/web-client/src/views/Practitioners/PractitionerCaseIcons.tsx @@ -11,8 +11,8 @@ export function PractitionerCaseIcons({
{formattedCase.isSealed && ( From 73d4d2b580fc2badb1d4b8dfe2a4c1bbf2c5151a Mon Sep 17 00:00:00 2001 From: Christopher Bisom Date: Mon, 21 Oct 2024 16:17:04 -0400 Subject: [PATCH 2/3] 10261-story: trigger build to see if weird test failure continues From 6b1f4123a6b834d66b92ae23763b2195edc1f849 Mon Sep 17 00:00:00 2001 From: Christopher Bisom Date: Mon, 21 Oct 2024 17:18:54 -0400 Subject: [PATCH 3/3] 10261-story: fix Icon title, thanks to feedback from Tom --- web-client/src/views/Practitioners/PractitionerCaseIcons.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web-client/src/views/Practitioners/PractitionerCaseIcons.tsx b/web-client/src/views/Practitioners/PractitionerCaseIcons.tsx index e5ab7b1914b..5c3c522ed3b 100644 --- a/web-client/src/views/Practitioners/PractitionerCaseIcons.tsx +++ b/web-client/src/views/Practitioners/PractitionerCaseIcons.tsx @@ -14,7 +14,7 @@ export function PractitionerCaseIcons({ aria-label="sealed" className="sealed-case-entry" icon="lock" - title={formattedCase.sealedToTooltip} + title="sealed" /> )} {formattedCase.inConsolidatedGroup && (