Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site - Styles: Borderless table headers have white background #2748

Open
mahoneycm opened this issue Jul 12, 2024 · 0 comments
Open

USWDS-Site - Styles: Borderless table headers have white background #2748

mahoneycm opened this issue Jul 12, 2024 · 0 comments
Labels
Good First Issue A good issue for those new to USWDS Needs: Confirmation We need to confirm that this is an issue Role: Dev Development/engineering skills needed

Comments

@mahoneycm
Copy link
Contributor

Description

Borderless table header cells have a white background that stands out from our off-white background.

Proposed solution

We should add custom styles or consider component theme settings to override the white background.

The $theme-table-background-color should use the site's background color by default if it's not being overridden.

Screenshots

From @mejiaj in this comment

image
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Jul 12, 2024
@mahoneycm mahoneycm added Good First Issue A good issue for those new to USWDS Role: Dev Development/engineering skills needed labels Jul 12, 2024
@mahoneycm mahoneycm mentioned this issue Jul 12, 2024
Merged
8 tasks
@brunerae brunerae added Needs: Confirmation We need to confirm that this is an issue and removed Status: Triage We're triaging this issue and grooming if necessary labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue A good issue for those new to USWDS Needs: Confirmation We need to confirm that this is an issue Role: Dev Development/engineering skills needed
Projects
USWDS Core Project Data
Status: Needs refinement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mahoneycm @brunerae