Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm deprecate versions prior to v7? #572

Closed
broofa opened this issue May 4, 2021 · 3 comments
Closed

npm deprecate versions prior to v7? #572

broofa opened this issue May 4, 2021 · 3 comments

Comments

@broofa
Copy link
Member

broofa commented May 4, 2021

This comment has me thinking we should do this:

npm deprecate uuid<7 "Pre-v7 versions of this library may use Math.random() \
in certain circumstances, which is known to be problematic.  Please upgrade to a \
more recent version.  See https://v8.dev/blog/math-random for details."
@ctavan
Copy link
Member

ctavan commented May 4, 2021

I don’t know exactly what consequences this will have. But in principle this sounds very good to me!

@LinusU
Copy link
Member

LinusU commented May 28, 2021

I think the only consequence would be a warning printed when running npm install?

I'm all for this 👍

@broofa
Copy link
Member Author

broofa commented May 28, 2021

Done. For the record, here's the command I ran:

npm deprecate uuid@"<7" "Please upgrade `uuid` to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details."

You can verify by going to https://www.npmjs.com/package/uuid and clicking the "Versions" tab, then selecting the "☑️ show deprecated versions" box to see which versions are / aren't deprecated.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants