Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muted list via NIP-51 #151

Merged
merged 13 commits into from
Jan 28, 2023
Merged

Muted list via NIP-51 #151

merged 13 commits into from
Jan 28, 2023

Conversation

verbiricha
Copy link
Collaborator

@verbiricha verbiricha commented Jan 27, 2023

Wanted to get some feedback on this, I think having a public mute list and the possibility to batch mute people is good, I can see who you've muted and preemptively mute them, wdyt?

I'm going to add a "Block" option (private mute) that stores the list of blocked p in the encrypted content field so we get public/private blocks. Not going to tackle other types of lists in this PR, just focused on mute list for p which I think is the most valuable atm. We can add pins and bookmarks later.

Closes #101

  • Mute (public)
  • Block (private)

@verbiricha
Copy link
Collaborator Author

Link to NIP PR: nostr-protocol/nips#183

@v0l v0l self-requested a review January 27, 2023 19:32
Copy link
Owner

@v0l v0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small bits, looks good though

src/Element/MutedList.tsx Show resolved Hide resolved
src/Element/NoteReaction.tsx Show resolved Hide resolved
src/Element/Timeline.tsx Outdated Show resolved Hide resolved
src/Feed/EventPublisher.ts Outdated Show resolved Hide resolved
src/Feed/LoginFeed.ts Show resolved Hide resolved
src/Feed/MuteList.ts Outdated Show resolved Hide resolved
src/Nostr/Tag.ts Outdated Show resolved Hide resolved
src/Pages/MessagesPage.tsx Outdated Show resolved Hide resolved
src/Pages/settings/Profile.tsx Show resolved Hide resolved
src/Feed/MuteList.ts Outdated Show resolved Hide resolved
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5e0b36f
Status: ✅  Deploy successful!
Preview URL: https://f2dd8567.snort-social.pages.dev
Branch Preview URL: https://mute.snort-social.pages.dev

View logs

src/Element/BlockList.tsx Outdated Show resolved Hide resolved
src/Element/NoteReaction.tsx Outdated Show resolved Hide resolved
src/Element/NoteReaction.tsx Outdated Show resolved Hide resolved
src/Feed/MuteList.ts Outdated Show resolved Hide resolved
@v0l v0l linked an issue Jan 28, 2023 that may be closed by this pull request
@verbiricha verbiricha marked this pull request as ready for review January 28, 2023 19:03
@v0l
Copy link
Owner

v0l commented Jan 28, 2023

When i click onto the muted persons profile it should show notes anyway?

@verbiricha
Copy link
Collaborator Author

good point, changed it so when visiting Profile the moderation is ignored.

@v0l v0l merged commit e019673 into new-ui Jan 28, 2023
@v0l v0l deleted the mute branch January 28, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Lists for storting block/mute lists
2 participants