Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extender causes forum loading to fail #51

Closed
luceos opened this issue Mar 16, 2021 · 3 comments · Fixed by #78
Closed

Extender causes forum loading to fail #51

luceos opened this issue Mar 16, 2021 · 3 comments · Fixed by #78
Labels
bug Something isn't working plannedupdate This issue is going to be resolved in an update. It is planned.

Comments

@luceos
Copy link
Contributor

luceos commented Mar 16, 2021

Error:

In case you have any extension enabled that uses the Extend class in this extension and this extension is not enabled, it will throw an unrecoverable exception.

Assumption:

I assume you are throwing this exception for issues in the past under similar circumstances.

Solution:

Use Container::make to get a singleton object. Core uses the same method, so in case the singleton has not yet been instantiated it will do now. The reason no Container is bound yet is because this extension wasn't booted.

@jaspervriends jaspervriends added bug Something isn't working plannedupdate This issue is going to be resolved in an update. It is planned. labels Mar 24, 2021
@jaspervriends
Copy link
Member

Issue is also reported via the Blog Extension v17development/flarum-blog#53 (reminder for me to update that issue too after fixing it)

@jaspervriends jaspervriends linked a pull request Jan 1, 2023 that will close this issue
@jaspervriends
Copy link
Member

Should be fixed in version 2.0 that will be released soon 🚀

@SKevo18
Copy link

SKevo18 commented Feb 18, 2024

Hi, any update on the 2.0 release? It seems that this issue is still present in the latest version of the SEO/Blog extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plannedupdate This issue is going to be resolved in an update. It is planned.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants