Performance issues in busy forums with the likes extension

[SychO9]

Hello! very useful extension for the ecosystem!

Issue
Someone reported a performance problem with what they believed was the flarum/likes extension: https://discuss.flarum.org/d/30913-huge-performance-problem-refreshing-takes-20sec-or-longer/. However, having looked into it, the problem stems from this extension, which was confirmed after enabling/disabling this extension.

These are the readings from clockwork:

I am not familiar with the source code, but a quick glance suggests the following:

• When a discussion is loaded, all of its posts are queried (https://github.com/v17development/flarum-seo/blob/master/src/Managers/QADiscussion.php#L73).
• For each post, all the likes are queried (https://github.com/v17development/flarum-seo/blob/master/src/Managers/QADiscussion.php#L175).

In a busy forum this can easily lead to significant performance issues.

Possible Solutions
I'm not familiar with the targetted behavior, but I'd look into these:

• Do all posts need to be loaded?
• For the likes count, instead of counting resulting queried models. Include the count with the initial posts query (https://laravel.com/docs/9.x/eloquent-relationships#relationship-counting-and-custom-select-statements).
• If this only occurs when a certain setting is ON, display a warning on the UI next to the specific setting explaining the dangers.

Thanks.

[jaspervriends]

Thanks for reporting! Will be fixed in 2.0 which will be released soon 🚀