-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: zlib-binding.deflate flaky #45
Comments
One of the things I've noticed on the other PR is that it's only flaky on the Rackspace hosts and not the Softlayer hosts. I think the only real difference is our Rackspace hosts have less memory and less CPU, but @nodejs/build could confirm. @addaleax suggested that it might would be helpful to log into a machine where its failing and run the test under |
FWIW I have seen it on Windows (EDIT: 2008 only IIRC) with vs2017 before, but it disappeared when I ran it using the stress-test job, and it disappeared on the full CI after a rebase: nodejs#17338 (comment) |
Yeah, without a reproduction I’d still say that trying to get something from valgrind or a similar tool would be best… |
Got a stack trace in canary:
|
It appears that nodejs#18241 may have fixed this. (Or maybe something else fixed it? Point is, I don't think I'm seeing it anymore!) |
I just sync'ed vee-eight-lkgr with upstream master. I'll consider this fixed. Thanks! |
The
async-hooks/test-zlib.zlib-binding.deflate.js
test is flaky since we updated Node to Node master yesterday. Any async hooks folks want to look into this cc @addaleax @trevnorris? @Trott is seeing acorrupted double-linked list
error with the same test (on Node master with his PR #17856).This is the builder: https://ci.chromium.org/p/v8/builders/luci.v8.try/v8_node_linux64_rel
Here's one of the builds with a malloc error: https://ci.chromium.org/p/v8/builds/b8957891491866158528
The text was updated successfully, but these errors were encountered: