-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(WAKU2-MESSAGE): added meta attribute to waku message #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSTM, but presumably depends on agreement on the RFC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
unrelated, but do we plan to include experimental feature fields in this repo? (i.e rln proof field on slot 21)
ref: https://github.com/waku-org/nwaku/blob/2f883f88e5264964a09f6bf19bef68a410745c33/waku/v2/protocol/waku_message/codec.nim#L60-L65
That's a good question, @rymnc. Note this comment in the RFC PR: vacp2p/rfc#573 (comment)
I would argue that the process would be something like this:
I think that this work is worth an RFC issue to track it and have the discussion there. |
Merging this PR, as the associated RFC has been approved an merged 😁 |
As part of the Message Unique ID initiative, a metadata optional application-specific field has been proposed.