Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isEmail to latest specs #469

Open
woverton opened this issue Dec 21, 2015 · 4 comments
Open

Update isEmail to latest specs #469

woverton opened this issue Dec 21, 2015 · 4 comments
Labels
🐛 bug needs-vote For edge-case feature requests that need popularity vote

Comments

@woverton
Copy link

Here is some good reading on the matter: http://dalibornasevic.com/posts/63-email-address-validation-and-encodings

@woverton
Copy link
Author

I understand that this could be a lot slower. Perhaps config option for what specs to use?

@chriso
Copy link
Collaborator

chriso commented Dec 21, 2015

You'll find that a whole bunch of these validate correctly after #258:

> validator.isEmail('"()<>[]:,;@\\\\\\"! #$%&\'*+-\/=?^_`{}| ~.a"@example.com')
true
> validator.isEmail('"pink panther"@example.com')
true
> validator.isEmail('"pink@panther"@example.com')
true
> validator.isEmail('pink.panther@localserver', {require_tld:false})
true
> validator.isEmail('über@münchen.com')
true

A handful don't, though:

@profnandaa
Copy link
Member

Quick question on this one, yes the spec allows these kind of emails, but which emails are actually used in practice? I'm yet to meet some of these emails, would like people to point me to some examples...

Does it mean that we might need to introduce some strict-mode of sorts to create a difference?

@profnandaa
Copy link
Member

Please place a 👍 vote on this comment if you need this feature for your project.

@profnandaa profnandaa added the needs-vote For edge-case feature requests that need popularity vote label Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug needs-vote For edge-case feature requests that need popularity vote
Projects
None yet
Development

No branches or pull requests

3 participants